-
Notifications
You must be signed in to change notification settings - Fork 2
feat: custom users tab #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
biome.jsonc
Outdated
"$schema": "https://biomejs.dev/schemas/2.0.6/schema.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a matching package.json version bump. do we not have biome as a dev dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by this? I've added biome a dev dependency and changed the schema URL to match.
biome.jsonc
Outdated
"experimentalScannerIgnores": [ | ||
"src/client/gen/types.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is what we want to use here. The docs say the new replacement for files.ignore
is actually...
{
"files": {
"include": ["!src/client/gen/types.ts"]
}
}
(note the !
in there)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to the new replacement but forgot to remove the old one 🤦
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still two open concerns about biome but everything else looks good
Closes #40