Skip to content

feat: custom users tab #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jul 21, 2025
Merged

feat: custom users tab #44

merged 24 commits into from
Jul 21, 2025

Conversation

brettkolodny
Copy link
Collaborator

Closes #40

Copy link

vercel bot commented Jul 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2025 8:31pm

@brettkolodny brettkolodny marked this pull request as ready for review July 8, 2025 20:37
@brettkolodny brettkolodny marked this pull request as draft July 9, 2025 15:43
@brettkolodny brettkolodny self-assigned this Jul 9, 2025
@brettkolodny brettkolodny marked this pull request as ready for review July 9, 2025 16:52
biome.jsonc Outdated
"$schema": "https://biomejs.dev/schemas/2.0.6/schema.json"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a matching package.json version bump. do we not have biome as a dev dependency?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by this? I've added biome a dev dependency and changed the schema URL to match.

biome.jsonc Outdated
Comment on lines 8 to 9
"experimentalScannerIgnores": [
"src/client/gen/types.ts",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is what we want to use here. The docs say the new replacement for files.ignore is actually...

{
  "files": {
    "include": ["!src/client/gen/types.ts"]
  }
}

(note the ! in there)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to the new replacement but forgot to remove the old one 🤦

Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still two open concerns about biome but everything else looks good

@brettkolodny brettkolodny merged commit 744725e into main Jul 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to add custom users
2 participants